Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

851 fix word completion logic #1487

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

851 fix word completion logic #1487

wants to merge 12 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Nov 24, 2024 •
edited
Loading

Fixes #851

  • Handle text being inserted at the start of a word
  • Handle delete_range signal, removing unused words from the prefix tree
  • Allow numeric delimiters as long as they aren't at the start of a word (allows variables with numbers in them to be suggested)

@colinkiama
Start handling insert_text signal instead of key press signal in word…
7dbf009 
… completion plugin

The 'insert_text' signal gives more detail about how the document contents have changed, giving us a way to more accurately update the prefix tree used for word completion
@colinkiama
Merge remote-tracking branch 'origin/master' into 851-fix-word-comple…
46cf5d4 
…tion-logic
@colinkiama
Word completion now adds words when multiple characters of text are a…
ec2cc9c 
…dded. Not just one character
@colinkiama
Bring back handling of words from text inserted that isn't at a word …
79e0429 
…boundaryto the Word Completion plugin
@colinkiama
Prepare for prefix tree word removal in word completion engine
8a6edf0
@colinkiama
word-completion: Add "remove" method to PrefixTree
27d585f
@colinkiama
Detect when text gets inserted between a word
ab7fa75
@colinkiama
word-completion: Support text being inserted between a word
f748c01
@jeremypw jeremypw linked an issue Nov 24, 2024 that may be closed by this pull request
Word completion not working properly. #851
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Word completion not working properly.
2 participants
@jeremypw @colinkiama